Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Allow using different resource group and listener name with the in memory server #10096

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
With this PR it is now possible to use different resource group and listener name with the in-memory server.
This will greatly simplify using the in-memory server in context where the control plane endpoint and the in-memory resources are managed separately or where the name of the cluster is not known in advance, e.g. E2E tests

Note: for convenience we will continue to use the same name for resource group and listener within the in-memory, but this is not required anymore for other consumers of the in-memory server

/area provider/infrastructure-in-memory

@k8s-ci-robot k8s-ci-robot added area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2024
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 7, 2024
@sbueringer
Copy link
Member

/approve

/assign @chrischdi

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jut two nits :-)

@fabriziopandini fabriziopandini force-pushed the inmemory-decouple-resourcegroup-and-listener-name branch from 8a0f512 to c05240e Compare February 8, 2024 20:26
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b57d6c6bcd1dd4ae76fb6e5fb5b7f9cd500ba177

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f7645b into kubernetes-sigs:main Feb 9, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 9, 2024
@fabriziopandini fabriziopandini deleted the inmemory-decouple-resourcegroup-and-listener-name branch February 24, 2024 13:26
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants